Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep/use-script: Convert useScript to TypeScript #296

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Sidsector9
Copy link
Member

Description of the Change

Converts the useScript hook to TypeScript.

Closes #

How to test the Change

Changelog Entry

Changed - Add TypeScript support to useScript

Credits

Props @fabiankaegy @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

github-actions bot commented Mar 1, 2024

Size Change: +4 B (0%)

Total Size: 65.7 kB

Filename Size Change
dist/index.js 65.7 kB +4 B (0%)

compressed-size-action

Copy link

cypress bot commented Mar 1, 2024

Passing run #731 ↗︎

0 6 0 0 Flakiness 0

Details:

move useScript to TS
Project: 10up Block Components Commit: 2b2b90d40a
Status: Passed Duration: 01:18 💡
Started: Mar 1, 2024 11:35 AM Ended: Mar 1, 2024 11:36 AM

Review all test suite changes for PR #296 ↗︎

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me :) Thanks!

@fabiankaegy fabiankaegy merged commit 8112649 into develop Mar 1, 2024
7 of 8 checks passed
@fabiankaegy fabiankaegy deleted the upkeep/use-script branch March 1, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants