Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing in custom search result render function to ContentSearch #294

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

fabiankaegy
Copy link
Member

Description of the Change

Allow passing in a custom renderItem component to the <ContentPicker> / ContentSearch. This is to customize the appearance of the search results.

Closes #

How to test the Change

Changelog Entry

Added - Ability to pass custom renderItem function to ContentPicker

Credits

Props @fabiankaegy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

Size Change: +238 B (0%)

Total Size: 65.7 kB

Filename Size Change
dist/index.js 65.7 kB +238 B (0%)

compressed-size-action

@fabiankaegy fabiankaegy added the [Type] Enhancement New feature or request label Feb 27, 2024
Copy link

🎉 A new testing version of this package has been published to NPM. You can install it with npm install @10up/block-components@testing-294

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice improvement!

@fabiankaegy fabiankaegy merged commit 9f1ec12 into develop Feb 27, 2024
8 checks passed
@fabiankaegy fabiankaegy deleted the feature/allow-custom-search-result-rendering branch February 27, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants