Avoid get_the_title texturization when auto-composing tweet

[johnwatkins0]

Description of the Change

This would close #72 .

@rickalee Discovered that some undecoded special characters (hyphens/dashes and quotation marks, specifically) were appearing in tweets generated by this plugin. On closer inspection, I found that the WP core function get_the_title was being used to generate the tweet body. That function applies several filters, one of which (unless overridden) is wptexturize. This is where the characters were coming from.

To fix it, I removed get_the_title in favor of accessing post_title from the WP post object directly.

This issue only occurred when the post title was tweeted, not when custom share text was entered.

Alternate Designs

We could alternatively continue to use get_the_title and selectively disable only the default filters causing the character issues. In this scenario, though, we would need to immediately re-add any removed filters to avoid causing side effects elsewhere, and this could become complicated. Probably not worth the effort.

Benefits

Characters in Tweets appear as expected.

Possible Drawbacks

Verification Process

Create a post whose title contains dashes and quotation marks. Turn on autosharing for the post. Publish the post. Verify that the characters appear as expected.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

Resolves #72

Changelog Entry

Bypass character texturization when the post title is tweeted

[dinhtungdu]

LGTM 👍