Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WP filter unnecessarily applied twice #70

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

johnwatkins0
Copy link
Member

Description of the Change

This resolves #69 by removing the second instance of the autoshare_for_twitter_tweet filter, which is only meant to appear once.

Alternate Designs

Benefits

Avoid side effects from having the filter applied twice.

Possible Drawbacks

Verification Process

The filter provides a way to modify tweet text send to the Twitter endpoint. Verification could involve checking that features making use of this filter are unaffected.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#69

Changelog Entry

Remove redundant filter

@johnwatkins0 johnwatkins0 self-assigned this Jan 28, 2020
@jeffpaul jeffpaul added this to the 1.1.0 milestone Jan 29, 2020
@jeffpaul jeffpaul requested a review from dinhtungdu January 29, 2020 15:07
@jeffpaul jeffpaul added the type:bug Something isn't working. label Jan 29, 2020
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@johnwatkins0 johnwatkins0 merged commit 16a9307 into develop Jan 29, 2020
@jeffpaul jeffpaul deleted the fix/redundant-filter branch June 30, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WP filter unnecessarily applied twice
3 participants