complete renaming tenup_autotweet -> autotweet

[adamsilverstein]

Description of the Change

Complete the renaming process, removing remaining references to "tenup_autotweet"

Completes fixes for #22.

Benefits

More consistent naming, namespaces for translations.

Possible Drawbacks

Any existing hook uses need name changes. However hook names were already changed in 1.0.0 and only one client use is impacted since this has been internal.

Verification Process

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

Changelog Entry

Changed

• Hook names have changed in the 1.0.0 release, pre-1.0.0 uses need to be adjusted to the new namespace. The part of the hook that previously was tenup_auto_tweet is now autotweet.

[johnwatkins0]

@adamsilverstein Looks good. See my comment for one more.

FWIW, tested this branch in WP 5.3 -- worked fine 😄

[johnwatkins0]

@adamsilverstein @jeffpaul This is ready for review. I continued on the branch originally intended for renaming things to "Autotweet." I've updated all "autotweets" of various forms to "autoshare." I also changed the plugin name to "Autoshare for Twitter" and changed the repo URL, path, text domain, post type support feature name, and main plugin file to autoshare-for-twitter. Let me know if you see anything else.

[jeffpaul]

@johnwatkins0 I see https://github.com/10up/autotweet/blob/fix/rename-part-2/auto-share-for-twitter.php and https://github.com/10up/autotweet/blob/fix/rename-part-2/autoshare-for-twitter.php, let's keep the auto-share one and get rid of the autoshare one

[johnwatkins0]

Thanks, @jeffpaul . Leaving auto-share-for-twitter.php in there was an oversight. Fixed now.

[jeffpaul]

My only other question, thinking out loud here, is whether we'd intend to create an Auto Share for (Facebook, LinkedIn, etc.) in which case we'd want some of the references here to denote auto-share-for-twitter / autoshare-for-twitter instead of just autoshare. I don't think it's very likely that we would create additional autoshare plugins in the near future, so I think we're ok to stick with the shorter autoshare references throughout the code.

[jeffpaul]

Also worth updating CHANGELOG.md for the 1.0 release to include:
- Plugin renamed to "Auto Share for Twitter". (props @johnwatkins0 via #49 )
after the "Initial public release" line.

[johnwatkins0]

@jeffpaul That's a good point re: other potential versions of "Autoshare" for other platforms. I could do another round of search-replacing in the code to change autoshare to autoshare-for-twitter, Autoshare to AutoshareForTwitter etc. without too much effort. It would make everything more verbose, but that's not a huge problem. I wonder, though, if 10up were to someday build similar tools for other platforms, would we actually build them as individual plugins for each? It seems more likely we'd group the functionality under a single plugin.

I'd be interested in @adamsilverstein view before I go CMD+F'ing in the project some more.

[adamsilverstein]

@johnwatkins0 I guess since we are submitting the plugin as "Autoshare for Twitter" it is going to get sutoshare-for-twitter as its plugin slug, it does make sense to keep all the naming and namespacing the same across the plugin.

[jeffpaul]

Ok, so to confirm we'll standardize on autoshare-for-twitter across the board. I'll update the repo name to reflect that and let @johnwatkins0 handle the remaining find/replace work.

[johnwatkins0]

@adamsilverstein @jeffpaul Took another pass through to replace Autoshare namespaces throughout with the equivalent Autoshare for Twitter namespaces. It's all working locally, but I'm a little nervous about how many changes there are, so I aim to go take another close look with a round of testing later in the week. Unless someone else is available to give it all another set of eyes.

[jeffpaul]

Made a couple small updates, otherwise looks good to me, nice work!

[jeffpaul]

nice work @johnwatkins0, I think we're clear to merge this when you're ready