Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show twitter status logs for the draft post if the post has been switched back to Draft from Published, and has already been Tweeted. #215

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Show twitter status logs for the draft post if the post has been switched back to Draft from Published, and has already been Tweeted. #215

merged 2 commits into from
Jan 6, 2023

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Jan 5, 2023 •
edited
Loading

Description of the Change

PR contains changes to Show Twitter status logs for the draft post if the post has been switched back to Draft from Published, and has already been Tweeted.

Gutenberg

Before After
Screenshot 2023-01-05 at 12 04 35 PM Screenshot 2023-01-05 at 12 04 02 PM

Classic Editor

Before After
Screenshot 2023-01-05 at 12 05 04 PM Screenshot 2023-01-05 at 12 05 25 PM

Closes #182

How to test the Change

Need to test the following steps with Gutenberg and classic editor.

  1. Create a post, publish it, and make sure it is tweeted.
  2. Switch back post to draft from published
  3. See the "Autotweet" document panel or the "Autoshare for Twitter" post metabox.
  4. Twitter status log should be visible and the option for tweeting on publish should also be there.

Changelog Entry

Changed - Show twitter status logs for the draft post if the post has been switched back to Draft from Published, and has already been Tweeted.

Credits

Props @iamdharmesh @jeffpaul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added the needs:code-review This requires code review. label Jan 5, 2023
@iamdharmesh iamdharmesh marked this pull request as draft January 5, 2023 06:48
@github-actions github-actions bot removed the needs:code-review This requires code review. label Jan 5, 2023
@iamdharmesh iamdharmesh marked this pull request as ready for review January 5, 2023 09:11
@iamdharmesh iamdharmesh requested review from a team and faisal-alvi and removed request for a team January 5, 2023 09:11
@github-actions github-actions bot added the needs:code-review This requires code review. label Jan 5, 2023
@iamdharmesh iamdharmesh added this to the 1.3.0 milestone Jan 5, 2023
@iamdharmesh iamdharmesh mentioned this pull request Jan 5, 2023
Closed
16 tasks
faisal-alvi
faisal-alvi approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamdharmesh thank you for the work. LGTM! Tested, and it's working as expected.

@jeffpaul jeffpaul merged commit 45b0f9a into develop Jan 6, 2023
@jeffpaul jeffpaul deleted the enhancement/182 branch January 6, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-alvi faisal-alvi faisal-alvi approved these changes

Assignees

@iamdharmesh iamdharmesh

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Handle re-tweet in case of post has been switched back to Draft from Published, and has already been Tweeted
3 participants
@iamdharmesh @faisal-alvi @jeffpaul