Migrate to Cypress 11 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdharmesh
requested review from
a team and
Sidsector9
and removed request for
a team
Sidsector9
requested changes
Dec 1, 2022
.github/workflows/cypress.yml
Outdated
| @@ -25,7 +25,7 @@ jobs: | |||
| uses: actions/checkout@v2 | |||
|
|
|||
| - name: Install dependencies | |||
| run: npm i && npm i -g cypress@9.0.0 | |||
| run: npm i && npm i -g cypress@11.2.0 | |||
There was a problem hiding this comment.
Is there a specific reason to install Cypress globally instead of using the local version?
There was a problem hiding this comment.
We set env vars from repo secrets for a twitter API key and secret. So, directly calling the cypress command in workflow instead of using npm scripts. see here
There was a problem hiding this comment.
@Sidsector9 I tried a different approach to setup cypress env variables and removed global cypress installation.
Sidsector9
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR upgrades the Cypress version to 11 and updates needed files as part of the migration.
Closes #199
How to test the Change
Make sure PR
PASSE2E tests check OR verify E2E tests locally.Changelog Entry
Credits
Props @iamdharmesh
Checklist: