upkeep/183: bump min WP and PHP versions #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidsector9
requested review from
a team and
iamdharmesh
and removed request for
a team
github-actions
bot
added
the
needs:feedback
|
@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
iamdharmesh
requested changes
Nov 1, 2022
There was a problem hiding this comment.
Thanks for the PR @Sidsector9, changes look good to me. Noticed one minor thing, I think we should update WP minimum version to 5.7 in E2E testing GH Action here as well.
Thanks.
github-actions
bot
added
needs:code-review
iamdharmesh
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Thanks for the changes @Sidsector9, LGTM 🚀
@jeffpaul could you please help with removing the required checks PHP minimum 7.2 and phpunit (7.3) which are no longer needed? to unblock merging here.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR bumps minimum WP and PHP versions.
Closes #183
Changelog Entry
Credits
Props @vikrampm1 @Sidsector9
Checklist: