Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Autotweet editor panel for enable/disable Autotweet and color-coded icon in Pre-Publish panel #177

Merged
merged 13 commits into from
Sep 2, 2022

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Jul 5, 2022

Description of the Change

As requested on #176, This PR adds slotfill for auto-tweet in the editor sidebar and also added a color-coded icon in the pre-publish panel. Please check screenshots for more information on this.

Editor Sidebar
Auto Tweet enabled image
Auto Tweet Disabled image
[Status] Tweeted Successfully image
[Status] Tweet Failed image
[Status] Not Tweeted image
Pre-Publish Panel
Auto Tweet enabled image
Auto Tweet Disabled image

Closes #176

Alternate Designs

Possible Drawbacks

n/a

Verification Process

  1. Go To Add a new post.
  2. Notice the dedicated panel for auto-tweet in the editor sidebar.
  3. Test enable/disable tweet on publish
  4. Click on publish
  5. Notice the pre-publish panel for auto-tweet with icon
  6. Test enable/disable tweet on publish
  7. Publish the post
  8. Verify the tweet status in panel of the editor sidebar (for failed, success, and not tweeted).

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - Autotweet panel in editor sidebar for enable/disable tweet on publish.

Credits

Props @iamdharmesh @jeffpaul @linawiezkowiak @oszkarnagy (for the UX/Design work)

@iamdharmesh iamdharmesh self-assigned this Jul 5, 2022
@iamdharmesh iamdharmesh changed the title Added Autotweet editor panel for enable/disable Autotweet. Added Autotweet editor panel for enable/disable Autotweet and color-coded icon in Pre-Publish panel Jul 6, 2022
@iamdharmesh iamdharmesh marked this pull request as ready for review July 6, 2022 07:11
@iamdharmesh iamdharmesh requested review from a team and cadic and removed request for a team July 6, 2022 07:11
@iamdharmesh iamdharmesh added this to the 1.2.0 milestone Jul 6, 2022
cadic
cadic previously approved these changes Aug 8, 2022
Copy link
Contributor

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

assets/css/admin-autoshare-for-twitter.css Outdated Show resolved Hide resolved
@iamdharmesh
Copy link
Member Author

Thanks for the review @cadic.

@jeffpaul can you please help to quick check on the wordings update in this PR? if anything needs to be updated.

Thanks

@iamdharmesh iamdharmesh requested a review from jeffpaul August 8, 2022 15:04
@iamdharmesh iamdharmesh requested a review from cadic August 26, 2022 07:25
cadic
cadic previously approved these changes Aug 27, 2022
src/js/index.js Outdated Show resolved Hide resolved
@jeffpaul
Copy link
Member

jeffpaul commented Sep 1, 2022

@iamdharmesh only one small copy suggestion, otherwise this looks great, thanks!

@iamdharmesh iamdharmesh merged commit 8991ffe into develop Sep 2, 2022
@iamdharmesh iamdharmesh deleted the enhancement/176 branch September 2, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants