-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Autotweet editor panel for enable/disable Autotweet and color-coded icon in Pre-Publish panel #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdharmesh
changed the title
Added Autotweet editor panel for enable/disable Autotweet.
Added Autotweet editor panel for enable/disable Autotweet and color-coded icon in Pre-Publish panel
Jul 6, 2022
iamdharmesh
requested review from
a team and
cadic
and removed request for
a team
July 6, 2022 07:11
cadic
previously approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Max Lyuchin <[email protected]>
cadic
previously approved these changes
Aug 27, 2022
jeffpaul
reviewed
Sep 1, 2022
@iamdharmesh only one small copy suggestion, otherwise this looks great, thanks! |
cadic
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As requested on #176, This PR adds slotfill for auto-tweet in the editor sidebar and also added a color-coded icon in the pre-publish panel. Please check screenshots for more information on this.
Closes #176
Alternate Designs
Possible Drawbacks
n/a
Verification Process
Checklist:
Changelog Entry
Credits
Props @iamdharmesh @jeffpaul @linawiezkowiak @oszkarnagy (for the UX/Design work)