Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump tested up to WordPress 6.0 #162

Merged
merged 1 commit into from
May 20, 2022
Merged

Bump tested up to WordPress 6.0 #162

merged 1 commit into from
May 20, 2022

Conversation

iamdharmesh
Copy link
Member

Description of the Change

Performed tests with WordPress core 6.0-RC3, Twenty Twenty Two theme

Tests performed:

  • Plugin activate/deactivate on WP6.0-RC3
  • Set up the plugin and connected to the Twitter account
  • Created a post and tested the Tweet feature with and without feature image.
  • Verified Twitter post has been created successfully.

Closes #159

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Changed - Bump tested up to WordPress 6.0

Credits

Props @iamdharmesh @vikrampm1

@iamdharmesh iamdharmesh self-assigned this May 20, 2022
@iamdharmesh iamdharmesh requested review from a team and Sidsector9 and removed request for a team May 20, 2022 13:01
@iamdharmesh iamdharmesh added this to the 1.2.0 milestone May 20, 2022
@jeffpaul jeffpaul merged commit 97e064d into develop May 20, 2022
@jeffpaul jeffpaul deleted the tweak/wp6.0 branch May 20, 2022 13:22
@jeffpaul
Copy link
Member

@iamdharmesh feel free to make a similar change to trunk to get that to deploy out to dotorg

@iamdharmesh
Copy link
Member Author

I have added this to trunk, but deploy to wp.org failed due to a missing build step, I will fix it next week. I have created issue for the same: #164

@iamdharmesh iamdharmesh modified the milestones: 1.2.0, 1.1.2 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Awaiting requested review from Sidsector9 Sidsector9 was automatically assigned from 10up/open-source-practice

Assignees

@iamdharmesh iamdharmesh

Labels
None yet
Projects
Open Source Practice
Archived in project
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

Test against WordPress 6.0
2 participants
@iamdharmesh @jeffpaul