Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: only run wpa on PHP 7.2 to save resource #101

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

I was wrong when I suggested running WPA on both 7.2 and 7.3. We only need to run that test one time because the PHP version is controlled by the snapshot, not the test environment. We can run WPA tests for other PHP versions by running tests against multiple snapshots.

Alternate Designs

Benefits

Save resources and build time.

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@dinhtungdu dinhtungdu requested a review from johnwatkins0 April 8, 2020 14:47
@dinhtungdu dinhtungdu self-assigned this Apr 8, 2020
@jeffpaul jeffpaul added this to the 1.1.0 milestone Apr 8, 2020
Copy link
Member

@johnwatkins0 johnwatkins0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking, @dinhtungdu . We're learning as we go 😄 . I'm merging.

@johnwatkins0 johnwatkins0 merged commit e39ae09 into develop Apr 9, 2020
@johnwatkins0 johnwatkins0 deleted the fix/only-run-wpa-one-time branch April 9, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants