Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Move to https #28

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Update: Move to https #28

merged 1 commit into from
Mar 4, 2020

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Feb 29, 2020 •
edited
Loading

Description of the Change

Use https for the plugin svn server. See #25

Alternate Designs

n/a

Benefits

We leave http around for legacy reasons, but there is no reason to continue to use it, the SVN servers work just fine (better, even) with ssl

Possible Drawbacks

n/a

Verification Process

Manual verification

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #25

Changelog Entry

@dinhtungdu dinhtungdu marked this pull request as ready for review February 29, 2020 09:49
@dinhtungdu dinhtungdu self-assigned this Feb 29, 2020
@dinhtungdu dinhtungdu mentioned this pull request Feb 29, 2020
Merged
6 tasks
@helen helen added this to the 1.5.0 milestone Mar 4, 2020
@helen helen merged commit f2b27ea into develop Mar 4, 2020
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Mar 6, 2020
@jeffpaul jeffpaul deleted the fix/25 branch March 11, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dinhtungdu dinhtungdu

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

Move to https
3 participants
@dinhtungdu @helen @jeffpaul