Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generate zip when version exists #133

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Support generate zip when version exists #133

merged 1 commit into from
Aug 8, 2023

Conversation

sy-records
Copy link
Contributor

Description of the Change

Closes #132

How to test the Change

Changelog Entry

Changed - Existing functionality

Credits

Props @sy-records

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@sy-records sy-records requested a review from a team as a code owner August 3, 2023 00:29
@sy-records sy-records requested review from faisal-alvi and removed request for a team August 3, 2023 00:29
@vikrampm1 vikrampm1 added this to the Future Release milestone Aug 3, 2023
@jeffpaul jeffpaul modified the milestones: Future Release, 2.3.0 Aug 3, 2023
faisal-alvi added a commit to faisal-alvi/action-wordpress-plugin-deploy that referenced this pull request Aug 7, 2023
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sy-records Thanks for the PR.

I have forked this repository and merged the code from this PR to the develop branch. I also had to disable the SVN_USERNAME and SVN_PASSWORD related code in order to skip the credential failures.

See https://github.com/faisal-alvi/action-wordpress-plugin-deploy/blob/develop/deploy.sh

Then I used it in another forked repository from SLA and published a release with the tag 1.1 which was already published but it does not generate a zip file.

See https://github.com/faisal-alvi/simple-local-avatars/actions/runs/5785384882

@iamdharmesh feel free to comment your thoughts here if there are any.

@sy-records
Copy link
Contributor Author

@sy-records sy-records requested a review from faisal-alvi August 7, 2023 14:09
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffpaul jeffpaul merged commit d2a8dc2 into 10up:develop Aug 8, 2023
@sy-records sy-records deleted the zip branch August 8, 2023 22:49
@dkotter dkotter modified the milestones: 2.3.0, 2.2.1 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the version already exists in SVN and generate-zip is configured, it should also generate the ZIP
5 participants