Update deploy.sh #115
Merged
Update deploy.sh #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed comment regarding unsure feature that enables users to set the version to use for the deployment.
|
Minor comment change here, I can see where the updated text might better apply now given the example use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed comment regarding unsure feature that enables users to set the version to use for the deployment.
Yes it makes sense to allow for custom setting of the version number in "advanced" workflows.
Here is an example where I need to set the version number manually by getting the latest plugin version that was uploaded to freemius and then use it as the svn tag version: https://github.com/UVLabs/freemius-wp-org-deploy/blob/main/workflows/upload-to-svn-from-freemius.yml