-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If IGNORE_OTHER_FILES is true, only copy readme.txt #32
Conversation
Still think this is worthwhile. |
@dinhtungdu @dhanendran given your work on other GH Actions, what's your take/review on the potential update here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's handy to copy only asset/readme. This will cause the readme/assets and the plugin source code out of sync because readme/assets are deployed independently now. But the flag is set to false
by default, if developers set the flag, it's their responsibility to keep the readme/assets and plugin source in sync.
@markjaquith Thanks a lot for the PR and sorry for the delay in review. PR looks good to me. just one minor change is needed in the readme, apart from that all good. Thanks again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adds an ENV variable
IGNORE_OTHER_FILES
which defaults tofalse
.If someone overrides it with
true
, then instead of the big complicated copying logic, this will happen:This means that the only thing that will be committed is
readme.txt
(trunk
and stable tag), and the assets.This maintains full back compat, but fixes #12