Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best workflow #28

Closed
janw-me opened this issue Apr 7, 2021 · 2 comments
Closed

Best workflow #28

janw-me opened this issue Apr 7, 2021 · 2 comments
Labels
type:question Further information is requested.

Comments

@janw-me
Copy link

janw-me commented Apr 7, 2021

Hello,

I'm using this action and the plugin deploy action.
Today I had a small bug fix I did the following steps.

  1. Changed a few php files, updated version numbers in the plugin file and in the readme.txt
  2. Committed this to the dev branch and pushed.
  3. merged dev to main branch
  4. This action runs and errors on Other files have been modified
  5. I create a release and create a tag.
  6. The plugin deploy action runs and deploys to WordPress.org
  7. All is well in the lands.

Is this the intended workflow? Is there a way to do this process without triggering the error in step 4.
There isn't a real problem but the failed pipeline insinuates that something went wrong, that there is a real error.

Maybe I'm missing something, I'm trying to understand how this should work.

@janw-me janw-me added the type:question Further information is requested. label Apr 7, 2021
@dinhtungdu
Copy link
Contributor

dinhtungdu commented Apr 8, 2021

Is this the intended workflow?

Hi @janw-me Yes, see this from the readme.md:

This Action commits any readme and WordPress.org-specific assets changes in your specified branch to the WordPress.org plugin repository if no other changes have been made since the last deployment to WordPress.org.

This behavior ensures you don't deploy new versions of the readme without respective changes deployed to wordpress.org.

@janw-me
Copy link
Author

janw-me commented Apr 8, 2021

I understand, Still it's a bit annoying to have "failed" actions when it's intended behaviour.

@janw-me janw-me closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Further information is requested.
Projects
None yet
Development

No branches or pull requests

2 participants