Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First time using it, getting an Other files have been modified; changes not deployed error #24

Closed
loureirorg opened this issue Aug 2, 2020 · 8 comments · Fixed by #46
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@loureirorg
Copy link

loureirorg commented Aug 2, 2020

Describe the bug
After installing the action on my repo, I created a trunk branch, changed the readme.txt file, and submitted the changes, getting an Other files have been modified; changes not deployed error.

Commit: thecodecrate/wordpress-plugin-export-users@635870e
Failed action: https://github.com/loureirorg/wordpress-plugin-export-users/runs/938044443?check_suite_focus=true

Steps to Reproduce

  1. Create a trunk branch (git checkout -b trunk);
  2. Change the readme.txt file (echo "\n" >> readme.txt);
  3. Submit the changes (git add readme.txt; git commit -m "Test"; git push origin trunk);
  4. On GitHub Actions see the error Other files have been modified; changes not deployed;

Expected behavior
Changes made on WordPress.org.

Additional context
I use the WordPress.org Plugin Deploy as my deploy tool I don't have any problems with it. Recently I decided to try WordPress.org Plugin Readme/Assets Update for small changes on the readme.txt file.

I strongly believe I am missing something and that's not an actual bug. Maybe it's because I didn't have a trunk repository and thus it is trying to submit all the contents at once.

I actually don't use a trunk for any of my Git projects - instead, I create a new branch and once the code is ready to be merged I do a PR. So maybe I am not using the trunk approach as it was intended to by this tool.

@loureirorg loureirorg added the type:bug Something isn't working. label Aug 2, 2020
@Tropicalista
Copy link

Same error here. Have you found a solution?

@jeffpaul
Copy link
Member

@loureirorg @Tropicalista you'll want to note the first line specifically in the readme (bolded text to call out likely issue):

This Action commits any readme and WordPress.org-specific assets changes in your specified branch to the WordPress.org plugin repository if no other changes have been made since the last deployment to WordPress.org.

Unfortunately that Action run log is no longer available, but I suspect that there were other changes in the branch that cause the action to fail (as designed).

@Tropicalista do you have a link to a commit and action log that I can review to try and help triage?

@jeffpaul jeffpaul self-assigned this Dec 17, 2020
@jeffpaul jeffpaul added type:question Further information is requested. needs:feedback This requires reporter feedback to better understand the request. and removed type:bug Something isn't working. labels Dec 17, 2020
@Tropicalista
Copy link

@jeffpaul
Copy link
Member

@Tropicalista you don't need the SLUG line if your GitHub repo matches the SVN repo (which yours appears to). Also, the same comment for @loureirorg above applies for you as it appears there are other changes in your master branch that haven't been deployed so the asset/readme update action will fail (as designed).

@ocean90
Copy link
Contributor

ocean90 commented Dec 18, 2020

This sounds similar to #12. Would be nice to to get that fixed once the remaining questions on the issue have been clarified.

@janw-me janw-me mentioned this issue Apr 7, 2021
@JohnRDOrazio
Copy link

JohnRDOrazio commented Apr 18, 2021

I'm having a bit of trouble myself. I recently created a github copy of my svn repo. And after a certain amount of development I am ready for a new release. I created a release, and the tag was successfully pushed to SVN with the tag-deploy.yml action (using 10up/[email protected]).
Then I modified the readme.txt, but on saving, the readme-deploy.yml action failed because it said it could not change into the directory .wordpress-org. Then I read about having the .wordpress-org directory as a mirror of the assets folder on the SVN repo. So I created this directory and added the assets to it, and pushed to github master/trunk branch. I also created a README.md alongside readme.txt for a better experience on Github. But now if I make any small changes to readme.txt in order to get the action to trigger, I'm getting the error that other changes have been made to the repo.

The only changes made since the last tag were the addition of the .wordpress-org folder with asset files, and a change to README.md. How can I force the action, so that I can get my latest release published on SVN?


UPDATE: I wound up simply creating another release. So I have two releases which are pretty much the same, but the first of these never actually got released on the WordPress plugins repository since the stable tag never pointed at it. Doing yet another release made sure the changes by adding the assets folder and all didn't prevent the release from happening the second time round.

@jeffpaul jeffpaul removed their assignment Apr 21, 2021
@jeffpaul jeffpaul added type:bug Something isn't working. and removed type:question Further information is requested. needs:feedback This requires reporter feedback to better understand the request. labels Apr 21, 2021
@jeffpaul jeffpaul added this to the 1.5.0 milestone Apr 21, 2021
@jeffpaul jeffpaul modified the milestones: 2.1.0, 2.2.0 May 11, 2022
@zaerl
Copy link
Contributor

zaerl commented Dec 1, 2022

@zaerl
Copy link
Contributor

zaerl commented Dec 5, 2022

Solved with #46.

Repository owner moved this from In Review to Merged in Open Source Practice Dec 8, 2022
@dkotter dkotter modified the milestones: 2.2.0, 2.1.2 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants