Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "Subscription Search" feature #44

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Adds "Subscription Search" feature #44

merged 4 commits into from
Feb 28, 2023

Conversation

ecaron
Copy link
Contributor

@ecaron ecaron commented Nov 6, 2022

Description of the Change

As discussed in 10up/ElasticPress#2867, and then submitted in 10up/ElasticPress#3029, this adds WooCommerce Subscription Search functionality to the WordPress admin section.

Note: This requires the hooks and filters introduced in 10up/ElasticPress#3029 to be functional

It also makes a small tweak to the class auto-loading to support developers using Windows, as well as bumped the composer dependencies to be in sync with the ElasticPress 4.2 libraries (necessary for PHP 8 support via phpunit).

How to test the Change

  1. Install any plugin that leverages WooCommerce subscription-core
  2. Add a subscription
  3. Within the search interface, do a search with & without ElasticPress enabled - the search results will be the same (albeit ElasticPress' results will return much faster)

Changelog Entry

Added - New lab feature to support searching the shop_subscription post type (identical to shop_order in all other ways)
Changed - Adjusted the method used to determine if classes are loaded to work on Mac, Linux & Windows

Credits

Props @ecaron, @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@ecaron ecaron changed the title Bumping to work with PHP 8 and Windows. Including functionality from PR3029 Adds "Subscription Search" feature Nov 6, 2022
@ecaron
Copy link
Contributor Author

ecaron commented Nov 9, 2022

@felipeelia This has been updated also as you suggested in 10up/ElasticPress#3029

@ecaron
Copy link
Contributor Author

ecaron commented Nov 9, 2022

Please let me know if you'd like the lint.yml updated to pass - looks like it could updated to sync with ElasticPress' lint.yml (in particular since chekalsky/phpcs-action was deprecated).

@felipeelia felipeelia merged commit 1a129bd into 10up:develop Feb 28, 2023
@ecaron ecaron deleted the feature/search-subscriptions branch February 28, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants