Avoid "Cannot declare class ElasticPressLabs" error #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on if ElasticPressLabs or ElasticPress plugin is loaded first, there's a situation where `core.php`'s `maybe_load_features` function and ElasticPress' `Features.php`'s `setup_features` both run - which causes the class to attempt two loads. Moving the `register_subfeatures` to `require_once` prevents this conflict, while keeping the other feature loading functionality in place.
4 tasks
|
@felipeelia Bump on this (trying to prep the PR for 10up/ElasticPress#3029) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Depending on if ElasticPressLabs or ElasticPress plugin is loaded first, there's a situation where
core.php'smaybe_load_featuresfunction and ElasticPress'Features.php'ssetup_featuresboth run - which causes the class to attempt two loads.Moving the
register_subfeaturestorequire_onceprevents this conflict, while keeping the other feature loading functionality in place.How to test the Change
Either change the order the plugins have been installed into your repo, or manually alter with WordPress'
activated_pluginaction. The behavior can be experienced if you toggle the load order between ElasticPress and ElasticPressLabs.Changelog Entry
Credits
Props @ecaron
Checklist: