Allow truthy values for enabling weighting #2597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentations show that `enabled => 1` can be used to enable the weighting for a field. - https://www.elasticpress.io/blog/2020/04/custom-fields-and-weighted-search-with-elasticpress/ - https://elasticpress.zendesk.com/hc/en-us/articles/360051543232-Search-all-meta-keys-matching-a-pattern It also came up on some issues e.g. 10up#2018 In order to fulfill this behaviour the type check was removed from the evaluation of the field.
|
Closing this one in favor of #2673. Thanks, @moritzlang! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Documentations show that
enabled => 1can be used to enable the weighting for a field.It also came up on some issues e.g. Add custom meta #2018
Description of the Change
In order to fulfill this behaviour the type check was removed from the evaluation of the field.
Alternate Designs
Possible Drawbacks
Verification Process
Tested locally.
Checklist:
Changelog Entry
Added possibility to enable weighting using truthy values
Credits
@moritzlang