-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init fix #402
Merged
Merged
Init fix #402
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1e19951
Fix init sed
tlovett1 2262aea
Remove trace
tlovett1 14afadf
Add space
tlovett1 d07de40
Fix bash script
tlovett1 d85bc50
Use bash
tlovett1 4193d9d
Fix deploy excludes; install toolkit in ci
tlovett1 959f9cc
Hardcode file excludes path
tlovett1 245a387
changeset
nicholasio 5559a24
Merge branch 'develop' into init-fix
tlovett1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"10up-toolkit": patch | ||
--- | ||
|
||
Fix init command |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
#!/bin/bash | ||
|
||
maybe_init_nvm() { | ||
|
||
if [ $(find . -name .nvmrc | wc -l) -gt 0 ] && [ ! -f $NVM_DIR/nvm.sh ]; then | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,7 +62,7 @@ | |
/** | ||
* Setuip environment variables | ||
* | ||
* @param {*} variables | ||
Check warning on line 65 in packages/toolkit/utils/project.js GitHub Actions / test (ubuntu-latest, 20)
|
||
*/ | ||
const setEnvVariables = (variables) => { | ||
// Loop through variables and set them as environment variables | ||
|
@@ -79,7 +79,7 @@ | |
* | ||
* @param {*} branch Branch name | ||
* @param {*} environments All environments | ||
* @returns {} | ||
Check warning on line 82 in packages/toolkit/utils/project.js GitHub Actions / test (ubuntu-latest, 20)
|
||
*/ | ||
const getEnvironmentFromBranch = (branch, environments = []) => { | ||
let matchedEnvironment = null; | ||
|
@@ -136,9 +136,8 @@ | |
data.build_script_path = `${projectRoot}/scripts/build.sh`; | ||
} | ||
|
||
if (!data.deploy_file_excludes) { | ||
data.deploy_file_excludes = `./toolkit/packages/toolkit/project/deploy-file-excludes.txt`; | ||
} | ||
data.deploy_file_excludes = `./scripts/deploy-excludes.txt`; | ||
data.deploy_file_excludes_absolute = `${projectRoot}/scripts/deploy-excludes.txt`; | ||
|
||
data.toolkit_path = resolve(`${__dirname}/../`); | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium