-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for scriptModule
and viewScriptModule
assets
#372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fac2194 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fabiankaegy
force-pushed
the
feature/wp-block-module-support
branch
from
March 19, 2024 19:16
8bd6d19
to
a07dcbe
Compare
fabiankaegy
changed the title
add basic module support as a POC
Add support for Mar 19, 2024
scriptModule
and viewScriptModule
assets
nicholasio
requested changes
Mar 25, 2024
nicholasio
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/RFC: #368
Description of the Change
Add support for
scriptModule
andviewScriptModule
assets defined inblock.json
files.These assets are handled by a separate instance of Webpack which is configured to output JS Modules instead of commonjs bundles.
In order to make this work we needed to split up the Webpack setup into two separate instances. One side-effect of this is that we can no longer run
clean
during watch mode since it would clean assets from the other webpack instance and therefore cause unexpected issues.Important
We need to determine what impact this PR has on how easy it is to extend toolkit with a custom Webpack config. Because we are changing the interface that we export from an object to now an array of objects.
Alternate Designs
I can't think of alternative designs for this.
Possible Drawbacks
The extensibility needs to be figured out. Also with two separate webpack instances this may be a little slower / use more resources.
Verification Process
The bundled example block in the 10up-theme project has both a regular script and also a view module which uses the interactivity API.
Checklist: