Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blocks or block for block directories #204

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Conversation

tlovett1
Copy link
Member

@tlovett1 tlovett1 commented Jun 7, 2022

For 10up UI Kit, we need to be able to put blocks in the directory block

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

🦋 Changeset detected

Latest commit: da9c394

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
10up-toolkit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@nicholasio nicholasio merged commit c5818e8 into develop Jun 7, 2022
@nicholasio nicholasio deleted the feature/block-dir branch June 7, 2022 14:55
@github-actions github-actions bot mentioned this pull request Jun 7, 2022
@fabiankaegy
Copy link
Member

@tlovett1 @nicholasio I'm a bit worried about this PR introducing unwanted issues for already existing projects. If you previously had a setup where you for example had styles located in a folder called block and are enqueueing them, they will all of the sudden stop working with this update.

Therefore this almost feels like a major version bump because we have introduced a potentially breaking change.

Overall this approach will no longer be necessary once we get #195 since we are moving away from the regex-based system of trying to figure out what is a block and what isn't in favor of using block.json for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants