Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structurize the alignment result #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nlhepler
Copy link
Contributor

@nlhepler nlhepler commented Feb 4, 2020

We expect a primary alignment, and maybe some secondary alignments.
In the case of no secondary alignments, its vec remains unalloced;

This may let us avoid holding around a vec per alignment that is more than likely empty (but still allocated, because we plucked the primary alignment from it).

We expect a primary alignment, and maybe some secondary alignments.
In the case of no secondary alignments, its vec remains unalloced;
Copy link
Contributor

@pmarks pmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

Copy link

@sreenathkrishnan sreenathkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants