Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support static compilation on Windows in lz4-sys crate #18

Merged
merged 3 commits into from
Mar 5, 2022

Conversation

analyzeDFIR
Copy link

The build script for the lz4-sys crate does not currently support static compilation on Windows, which requires passing the /MT flag. Unfortunately, cargo does not expose the RUSTFLAGS environment variable to build scripts (see: rust-lang/cargo#4423). This PR adds support for a CRT_STATIC environment variable in the build script which triggers adding the /MT flag for msvc builds only, and updates the CI workflow to test 32 and 64-bit dynamic and static builds on Windows. I also ran rustfmt on the build script which changed some formatting on existing code, but feel free to reject those formatting changes.

@pmarks pmarks merged commit 807a82b into 10XGenomics:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants