Support static compilation on Windows in lz4-sys crate #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws with latest version of Rust (1.53.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build script for the
lz4-syscrate does not currently support static compilation on Windows, which requires passing the/MTflag. Unfortunately, cargo does not expose theRUSTFLAGSenvironment variable to build scripts (see: rust-lang/cargo#4423). This PR adds support for aCRT_STATICenvironment variable in the build script which triggers adding the/MTflag formsvcbuilds only, and updates the CI workflow to test 32 and 64-bit dynamic and static builds on Windows. I also ranrustfmton the build script which changed some formatting on existing code, but feel free to reject those formatting changes.