[WIP] re-instate reference version check #11
Conversation
nlhepler
changed the title
source/Genome.cpp
Outdated
| @@ -140,13 +140,13 @@ void Genome::genomeLoad(){//allocate and load Genome | |||
| errOut << "EXITING because of FATAL ERROR: read no value for the versionGenome parameter from genomeParameters.txt file\n"; | |||
| errOut << "SOLUTION: please re-generate genome from scratch with the latest version of STAR\n"; | |||
| exitWithError(errOut.str(),std::cerr, P.inOut->logMain, EXIT_CODE_GENOME_FILES, P); | |||
| } else if (P1.versionGenome == P.versionGenome) {// | |||
| } else if (P1.versionGenome == P.versionGenome || (!P.quant.yes && P1.versionGenome == "20201")) {// | |||
There was a problem hiding this comment.
Could you please add a comment here to indicate that versionGenome of 20201 corresponds to STAR 2.5.1b? Otherwise LGTM. Thanks, Lance!
There was a problem hiding this comment.
or 2.7.1a rather re
20201 jumps straight to 2.7.1a, so these are the only supported versions at present.
|
Do we use |
|
20201 jumps straight to 2.7.1a, so these are the only supported versions at present. |
|
So this PR will work with |
|
@sjackman I leave that as an exercise for you. But cellranger under STAR 2.5.1b already required at least version 20201, so that would de-facto be the minimum version supported. |
Right! I had forgotten that the STAR that shipped with Cell Ranger 3.1 had the version check enabled. It wasn't defeated until the first Orbit commit ace1642. |
|
This brings orbit into parity with the 2.7.2a-tenx branch. Will merge if testing passes and update the relevant orbit PR. |
No description provided.