Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Extract SPI.beginTransaction from select/deselect callbacks as it breaks when called in ISR context from mbed-based boards. #82

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fix: Extract SPI.beginTransaction from select/deselect callbacks as it breaks when called in ISR context from mbed-based boards. #82

merged 1 commit into from
Apr 3, 2023

Conversation

aentinger
Copy link
Member

@aentinger aentinger commented Mar 23, 2023 •
edited
Loading

No description provided.

@aentinger
Fix: Extract SPI.beginTransaction from select/deselect callbacks as i…
90909b5 
…t breaks when called in ISR context from mbed-based boards.
@aentinger aentinger added type: enhancement PR to improve the project. topic: firmware Code that runs on an embedded system. labels Mar 23, 2023
@aentinger aentinger self-assigned this Mar 23, 2023
@aentinger aentinger mentioned this pull request Mar 23, 2023
Closed
@github-actions
Copy link

Memory usage change @ 90909b5

Board flash % RAM for global variables %
arduino:mbed_edge:edge_control 💚 -64 - -64 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 💚 -64 - 0 -0.01 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 💚 -16 - -16 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrfox1200 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
rp2040:rp2040:rpipico 💚 -16 - -16 -0.0 - -0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/MCP2515-CAN-Sniffer
flash		 % examples/MCP2515-CAN-Sniffer
RAM for global variables		 % examples/MCP2515-Filter
flash		 % examples/MCP2515-Filter
RAM for global variables		 % examples/MCP2515-Loopback
flash		 % examples/MCP2515-Loopback
RAM for global variables		 %
arduino:mbed_edge:edge_control -64 -0.01 0 0.0 -64 -0.01 0 0.0 -64 -0.01 0 0.0
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 -64 -0.01 0 0.0 -64 -0.01 0 0.0
arduino:mbed_nano:nanorp2040connect -16 -0.0 0 0.0 -16 -0.0 0 0.0 -16 -0.0 0 0.0
arduino:samd:mkr1000 -16 -0.01 0 0.0 -16 -0.01 0 0.0 -16 -0.01 0 0.0
arduino:samd:mkrfox1200 -16 -0.01 0 0.0 -16 -0.01 0 0.0 -16 -0.01 0 0.0
arduino:samd:mkrgsm1400 -16 -0.01 0 0.0 -16 -0.01 0 0.0 -16 -0.01 0 0.0
arduino:samd:mkrnb1500 -16 -0.01 0 0.0 -16 -0.01 0 0.0 -16 -0.01 0 0.0
arduino:samd:mkrvidor4000 -16 -0.01 0 0.0 -16 -0.01 0 0.0 -16 -0.01 0 0.0
arduino:samd:mkrwan1300 -16 -0.01 0 0.0 -16 -0.01 0 0.0 -16 -0.01 0 0.0
arduino:samd:mkrwan1310 -16 -0.01 0 0.0 -16 -0.01 0 0.0 -16 -0.01 0 0.0
arduino:samd:mkrwifi1010 -16 -0.01 0 0.0 -16 -0.01 0 0.0 -16 -0.01 0 0.0
arduino:samd:mkrzero -16 -0.01 0 0.0 -16 -0.01 0 0.0 -16 -0.01 0 0.0
rp2040:rp2040:rpipico -16 -0.0 0 0.0 -16 -0.0 0 0.0 -16 -0.0 0 0.0
Click for full report CSV 
Board,examples/MCP2515-CAN-Sniffer<br>flash,%,examples/MCP2515-CAN-Sniffer<br>RAM for global variables,%,examples/MCP2515-Filter<br>flash,%,examples/MCP2515-Filter<br>RAM for global variables,%,examples/MCP2515-Loopback<br>flash,%,examples/MCP2515-Loopback<br>RAM for global variables,%
arduino:mbed_edge:edge_control,-64,-0.01,0,0.0,-64,-0.01,0,0.0,-64,-0.01,0,0.0
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,-64,-0.01,0,0.0,-64,-0.01,0,0.0
arduino:mbed_nano:nanorp2040connect,-16,-0.0,0,0.0,-16,-0.0,0,0.0,-16,-0.0,0,0.0
arduino:samd:mkr1000,-16,-0.01,0,0.0,-16,-0.01,0,0.0,-16,-0.01,0,0.0
arduino:samd:mkrfox1200,-16,-0.01,0,0.0,-16,-0.01,0,0.0,-16,-0.01,0,0.0
arduino:samd:mkrgsm1400,-16,-0.01,0,0.0,-16,-0.01,0,0.0,-16,-0.01,0,0.0
arduino:samd:mkrnb1500,-16,-0.01,0,0.0,-16,-0.01,0,0.0,-16,-0.01,0,0.0
arduino:samd:mkrvidor4000,-16,-0.01,0,0.0,-16,-0.01,0,0.0,-16,-0.01,0,0.0
arduino:samd:mkrwan1300,-16,-0.01,0,0.0,-16,-0.01,0,0.0,-16,-0.01,0,0.0
arduino:samd:mkrwan1310,-16,-0.01,0,0.0,-16,-0.01,0,0.0,-16,-0.01,0,0.0
arduino:samd:mkrwifi1010,-16,-0.01,0,0.0,-16,-0.01,0,0.0,-16,-0.01,0,0.0
arduino:samd:mkrzero,-16,-0.01,0,0.0,-16,-0.01,0,0.0,-16,-0.01,0,0.0
rp2040:rp2040:rpipico,-16,-0.0,0,0.0,-16,-0.0,0,0.0,-16,-0.0,0,0.0

@aentinger aentinger marked this pull request as ready for review April 3, 2023 10:30
@aentinger
Copy link
Member Author

Does not fix #81 . But its a nice simplification none-the-less.

@aentinger aentinger merged commit b6b3061 into main Apr 3, 2023
@aentinger aentinger deleted the fix-mbed branch April 3, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aentinger aentinger

Labels
topic: firmware Code that runs on an embedded system. type: enhancement PR to improve the project.
Projects
Cyphal/Arduino
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aentinger