[TECH] Aligner les montées de versions npm / node sur le mono repo (PIX-6533) #5371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xav-car
force-pushed
the
pix-6533-relax-npm-package
branch
2 times, most recently
from
a279bf1 to
79881aa
Compare
octo-topi
changed the title
|
I'm deploying this PR to these urls:
Please check it out! |
octo-topi
changed the title
octo-topi
approved these changes
Dec 16, 2022
yannbertrand
force-pushed
the
pix-6533-relax-npm-package
branch
from
5ca61b6 to
5ead095
Compare
yannbertrand
approved these changes
Dec 16, 2022
yannbertrand
force-pushed
the
pix-6533-relax-npm-package
branch
from
5ead095 to
46f9509
Compare
pix-service-auto-merge
force-pushed
the
pix-6533-relax-npm-package
branch
from
46f9509 to
0b246a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
On ne veut pas imposer une version mineure de node, mais
pix-uien imposait une (transitivement).🎁 Proposition
Suite à cet ADR.
Monter en version 20.2.4 de pix-ui qui ne vérifie plus que la version majeure de node.
Puis relâcher le check dans le
package.jsonetnpm installpour mettre à jour lepackage-lock.json.Impact : Notre version de prod de node devient la 16.19.0, et npm 8.19.3.
🌟 Remarques
J'ai remplacé toutes nos références à [email protected] vers 16.18.1.
🎅 Pour tester
Vérifier que tout démarre sur les RA.
Vérifier que le script de configure.sh à l'onboarding fonctionne toujours.