[BUGFIX] Mettre le bouton pour fermer la bannière de nouveauté dans un vrai bouton #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotime2005
changed the title
|
Fix #726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Dans la bannière de nouveauté, le bouton "fermer" apparaissait comme une image pour les lecteurs d'écran et non comme un bouton.
🌰 Proposition
Mettre cette image et son action dans une simple balise de type button.
🎃 Remarques
Je n'ai pas pu vérifier qu'il s'agissait du bon bouton car impossible de mettre en place l'environnement de travail, il faudrait retravailler la doc.
🪵 Pour tester
Se rendre sur la page principal. Si une bannière de nouveauté s'affiche, vérifier que le bouton fermer est bien un bouton et pas seulement une image.