[BUGFIX] Réparer l'affichage des images en preview (PIX-14766) #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr701/environment |
Jeyffrey
force-pushed
the
fix-nuxt-image-provider-2
branch
3 times, most recently
from
8b3455e to
5083dcb
Compare
er-lim
reviewed
Oct 10, 2024
Jeyffrey
changed the title
er-lim
force-pushed
the
fix-nuxt-image-provider-2
branch
2 times, most recently
from
4fd9105 to
96fd1b3
Compare
er-lim
force-pushed
the
fix-nuxt-image-provider-2
branch
from
96fd1b3 to
c62154c
Compare
Jeyffrey
added
Tech Review OK
team-evaluation
er-lim
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
L'affichage de nouvelles images ne s'affichent plus lors des preview Prismic.
Cela est causée par les changements effectuées pour intégrer les images au build de l'application.
Les nouvelles images en preview ne sont pas intégrées au build ce qui cause ce problème.
🤖 Proposition
Ajouter une variable d'environnement IS_BUILTIN_IMAGES_ENABLED pour gérer ce comportement.
🌈 Remarques
RAS
💯 Pour tester
pix-siteen ajoutant cette nouvelle image.Preview the pageen choisissant Test images (pix.fr)pix-proen ajoutant cette nouvelle image.Preview the pageen choisissant Test images (pro.fr)