[BUGFIX] Télécharger tous les assets disponibles #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yann Bertrand <[email protected]>
VincentHardouin
changed the title
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr674/environment |
|
Plus de |
|
Il n'y a plus d'assets téléchargées en dehors de Scalingo ✅ On passe à 3.3MB téléchargés sur la home. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Lorsque des params sont passés au serveur h3, le serveur ne veut pas les gérer et l'url est skippé ce qui fait que l'asset n'est pas téléchargé
🤖 Proposition
Sur notre fork nous retirons les params envoyé au h3 et par conséquent à Prismic cela peut donc avoir des impacts sur les tailles d'images demandés 1024pix/nuxt-image@7f6025d
Le vrai correctif aurait été de faire en sorte que le h3 accepte et transfère les params à voir plus tard
🌈 Remarques
💯 Pour tester