-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Ajouter un linter (PIX-11730) #644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasferraina
added
🚧 Development in progress
team-evaluation
PR relatives à l'expérience d'évaluation
labels
Mar 21, 2024
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr644/environment |
matthiasferraina
force-pushed
the
pix-11730-add-linter
branch
from
March 28, 2024 15:06
bd88805
to
0854d42
Compare
matthiasferraina
added
cross-team
Toutes les équipes de dev
and removed
team-evaluation
PR relatives à l'expérience d'évaluation
labels
Mar 28, 2024
matthiasferraina
force-pushed
the
pix-11730-add-linter
branch
from
March 29, 2024 07:53
0376c58
to
4862201
Compare
matthiasferraina
added
👀 Tech Review Needed
and removed
🚧 Development in progress
labels
Mar 29, 2024
er-lim
approved these changes
Mar 29, 2024
matthiasferraina
force-pushed
the
pix-11730-add-linter
branch
from
March 29, 2024 10:54
5c52afa
to
9bd5bba
Compare
matthiasferraina
force-pushed
the
pix-11730-add-linter
branch
5 times, most recently
from
April 9, 2024 14:51
62669ed
to
a7f7dfd
Compare
matthiasferraina
added
Tech Review OK
Func Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
cross-team
Toutes les équipes de dev
labels
Apr 9, 2024
Co-authored-by: Eric Lim <[email protected]>
Co-authored-by: Eric Lim <[email protected]>
pix-service-auto-merge
force-pushed
the
pix-11730-add-linter
branch
from
April 9, 2024 15:32
a7f7dfd
to
f98501b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Suite à la migration en nuxt 3, il n'y a plus de linter sur le projet.
🤖 Proposition
Remettre un linter
🌈 Remarques
💯 Pour tester
Regarder le code, s'éblouir de sa beauté et de son uniformité.
Ouvrir un fichier, taper du javascript incorrect au sens du linter. Constater son interpretation en tant que code incorrect par l'IDE.