[FEATURE] Changer le design du locale switcher en affichage réduit (PIX-7356). #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr537/environment |
Thomasevano
changed the title
reibecca
reviewed
May 16, 2023
Thomasevano
force-pushed
the
pix-7356-change-mobile-locale-switcher-design
branch
from
879b79c to
46de58c
Compare
igorissen
reviewed
May 17, 2023
reibecca
reviewed
May 17, 2023
er-lim
reviewed
May 17, 2023
er-lim
reviewed
May 17, 2023
Thomasevano
force-pushed
the
pix-7356-change-mobile-locale-switcher-design
branch
from
46de58c to
576f8b6
Compare
reibecca
approved these changes
May 17, 2023
Thomasevano
force-pushed
the
pix-7356-change-mobile-locale-switcher-design
branch
3 times, most recently
from
b5e26c6 to
a9be156
Compare
Thomasevano
force-pushed
the
pix-7356-change-mobile-locale-switcher-design
branch
from
a9be156 to
07b67c5
Compare
|
Tests fonctionnels sur Chrome & Safari ✅ |
er-lim
approved these changes
May 19, 2023
igorissen
approved these changes
May 22, 2023
igorissen
added
🚀 Ready to Merge
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
pix-service-auto-merge
deleted the
pix-7356-change-mobile-locale-switcher-design
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
En mode réduit le locale switcher n'affichait pas les icônes.
🤖 Proposition
Retravailler le design afin d'afficher les icônes correspondant aux locales.
🌈 Remarques
child.icon === 'globe-europe.svg'présent ligne 99 de localeSwitcher.vue est temporaire le temps que l'on passe de localeen-gbversen, ensuite on créera une méthode qui vérifiera le localeCode dans une prochaine PR:💯 Pour tester