[BUGFIX] Affichage burger menu sur pro.pix.fr (PIX-5051) #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeyffrey
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
|
I'm deploying this PR to these urls:
Please check it out! |
yannbertrand
approved these changes
Jun 8, 2022
clarissedmn
approved these changes
Jun 9, 2022
squirrel4k
approved these changes
Jun 9, 2022
Jeyffrey
added
🚀 Ready to Merge
Func Review OK
Tech Review OK
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Le burger menu ne s'affiche pas en mode mobile sur le site pro.pix.fr.
🤖 Solution
Ajouter les variables d'environnement dans le fichier
nuxt.config.js.En affichage côté client, il est nécessaire de déclarer la clé
envpour que Nuxt soit capable de les lire (voir commentaire).🌈 Remarques
RAS
💯 Pour tester
Vérifier le bon comportement du menu sur les 4 sites en review-app, en mode mobile et desktop.