[TECH] Supprime des fichiers inutiles de l'image compilée (PIX-4805) #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
added
👀 Tech Review Needed
cross-team
|
I'm deploying this PR to these urls:
Please check it out! |
francois2metz
approved these changes
Apr 19, 2022
yannbertrand
changed the title
yannbertrand
force-pushed
the
tech-add-slugignore
branch
from
b777b82 to
e46fcd0
Compare
VincentHardouin
approved these changes
Apr 19, 2022
yannbertrand
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Après le build, lors du déploiement, Scalingo construit et sauvegarde une image de l'application. Cette image n'a besoin d'intégrer que ce qui est nécessaire pour lancer un ou plusieurs containers (dans notre cas : la config nginx et le dossier
dist).Aujourd'hui cette image contient la totalité du projet qui a permis de builder (y compris les
node_modules) soit plusieurs centaines de MB de fichiers et dossiers inutiles (au total l'image embarque 627MB).🤖 Solution
De la même manière que sur 1024pix/pix, utiliser un fichier de config
.slugignorepour retirer ces fichiers/dossiers inutiles.🌈 Remarques
RAS
💯 Pour tester
$ scalingo run -a pix-site-integration bash$ ls -alne doit plus renvoyer les dossiers et fichiers listés dans notre.slugignore, en particulier lenode_modules$ du -sh .pour vérifier qu'on a moins de 627MB de fichiers embarqués (probablement beaucoup moins)