-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Redirige les pages localisées de pix.fr vers pix.org (PIX-4496) #375
Merged
pix-service-auto-merge
merged 4 commits into
dev
from
fix-redirect-pix-fr-locale-to-pix-org
Mar 3, 2022
Merged
[BUGFIX] Redirige les pages localisées de pix.fr vers pix.org (PIX-4496) #375
pix-service-auto-merge
merged 4 commits into
dev
from
fix-redirect-pix-fr-locale-to-pix-org
Mar 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
PR relatives à l'expérience d'évaluation
team-captains
labels
Mar 3, 2022
I'm deploying this PR to these urls:
Please check it out! |
1 similar comment
I'm deploying this PR to these urls:
Please check it out! |
yannbertrand
changed the title
[BUGFIX] Redirige les pages localisées de pix.fr vers pix.org
[BUGFIX] Redirige les pages localisées de pix.fr vers pix.org (PIX-4496)
Mar 3, 2022
yannbertrand
commented
Mar 3, 2022
nlepage
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mickaelalibert
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yannbertrand
added
🚀 Ready to Merge
Func Review OK
Tech Review OK
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Func Review OK
🚀 Ready to Merge
team-captains
team-evaluation
PR relatives à l'expérience d'évaluation
Tech Review OK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Les sources de pix.fr et pix.org sont sur le même serveur. Ainsi les pages localisées qui commencent par
/fr-be
,/en-gb
,/fr
sont accessibles sur pix.fr.🤖 Solution
Cette première PR redirige des pages localisées de pix.fr vers pix.org pour clarifier la situation.
Des liens externes pointent vers pix.fr/fr, on a contacté les personnes maintenant ces sites d'autre part pour qu'elles renvoient vers les bons liens.
🌈 Remarques
Cette modif devrait également permettre de désindexer sur Google ces pages incorrectes.
La next step une fois qu'on aura le retour des mainteneurs d'autres sites sera de couper ces pages.
💯 Pour tester
Vérifier sur la RA que les pages <RA.fr>/fr, <RA.fr>/fr-be, <RA.fr>/en-gb renvoient bien vers <RA.org> sur la même page.