[BUGFIX] Suppression de liens vers pix.fr/fr et pix.fr/en-gb #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
|
I'm deploying this PR to these urls:
Please check it out! |
nlepage
approved these changes
Mar 1, 2022
VincentHardouin
approved these changes
Mar 1, 2022
squirrel4k
approved these changes
Mar 2, 2022
yannbertrand
added
🚀 Ready to Merge
Func Review OK
Tech Review OK
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
pix-service-auto-merge
force-pushed
the
fix-liens-fr-fr
branch
from
8c372f1 to
d86900a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Sur pix.fr, dans le burger menu, les liens des pages internationales renvoient vers pix.fr alors qu'ils devraient renvoyer pix.org. On avait oublié de passer par la méthode permettant de construire le lien absolu dans ce cas ci.
🤖 Solution
Utiliser la méthode
useGetAbsoluteUrlIfSwitchWebsitepour construire les liens absolus vers pix.org si nécessaire.🌈 Remarques
RAS
💯 Pour tester
Vérifier sur la RA en mobile que les liens du burger menu permettent de naviguer correctement entre pix.fr et pix.org.