[BUGFIX] Ne pas inclure les routes à générer si la langue n'est pas gérée (PIX-4173) #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
added
👀 Tech Review Needed
team-evaluation
|
I'm deploying this PR to these urls:
Please check it out! |
alexandrecoin
approved these changes
Jan 18, 2022
yannbertrand
changed the title
nlepage
approved these changes
Jan 18, 2022
yannbertrand
added
🚀 Ready to Merge
Tech Review OK
and removed
👀 Tech Review Needed
labels
pix-service-auto-merge
force-pushed
the
fix-build-routes-unhandled-language
branch
from
14fa72c to
f3f8b42
Compare
pix-service-auto-merge
deleted the
fix-build-routes-unhandled-language
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Jusqu'à présent nous n'avions jamais conditionné les langages disponibles. Avec l'arrivée de
fr-be, certaines pages de typesimple_pageetform_pagen'arrivent pas à builder en prod car on ne gère pas encore cette langue côté appli.Lors de la récupération des routes à générer l'API Prismic ne permet de récuperer seulement une langue ou la totalité des langues.
🤖 Solution
Le correctif consiste à filtrer les langues, après avoir tout récupéré, si on ne les gère pas dans l'application.
🌈 Remarques
RAS
💯 Pour tester
Vérifier que le build de la RA passe toujours (avec
fr-be).Vérifier que le build en local fonctionne toujours (sans
fr-be=>IS_FR_BE_LANGUAGE_LOCALE_AVAILABLE=false)