[BUGFIX] Boucle infinie Nginx sur les 404 pix.org #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When accessing an unknown URL to pix.org (e.g. pix.org/fr/not-existing-page), Nginx try to access /404.html. But the `rewrite` rules forces to 301 permanent redirect to /fr/404.html which doesn't exist and add /fr again. Before finding a best solution, this is a small patch to avoid the Nginx infinite loop.
yannbertrand
added
👀 Tech Review Needed
👀 Func Review Needed
cross-team
|
I'm deploying this PR to these urls:
Please check it out! |
nlepage
approved these changes
Dec 14, 2021
MelanieMEB
approved these changes
Dec 14, 2021
yannbertrand
added
🚀 Ready to Merge
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Lorsque l'on accède à une erreur 404 sur pix.org on tombe dans une boucle infinie Nginx qui rajoute des /fr devant notre page.
🤖 Solution
🌈 Remarques
Pour le moment, ceci ne permet pas les traductions d'erreur (qui ne sont pas prêtes de toute façon). Il faudra creuser plus loin pour trouver une solution internationisable plus tard.
💯 Pour tester
Vérifier sur la RA pix.org que les erreurs 404 s'affichent correctement.