[BUGFIX] Ajout de roles sémantiques dans les balises html (PIX-3999) #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrel4k
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
|
I'm deploying this PR to these urls:
Please check it out! |
squirrel4k
changed the title
yannbertrand
approved these changes
Dec 9, 2021
MelanieMEB
approved these changes
Dec 9, 2021
squirrel4k
added
🚀 Ready to Merge
Func Review OK
Tech Review OK
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
pix-service-auto-merge
deleted the
Fix/PIX-3999-AddSemanticRolesAttributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Manquement des balises d'accessibilité pour permettre une lecture simplifié pour le screen reader.
🤖 Solution
Ajout dans les différentes balises HTML d'un rôle que le screen reader va interpréter
🌈 Remarques
Pour le menu hamburger, nous n'avons pas réussi à ajouter le rôle " navigation" car on utilise un package.
Une demande de PR a été fait pour ajouter le rôle dans le package.
Le rôle "contentinfo" est déjà présent pour le footer.
💯 Pour tester
Accéder aux RA.
Vérifier via la console si les rôles suivant sont accessibles dans les balises:
<main role="main"/><nav role="navigation"/><header role="banner"/>