[FEATURE] Corriger les titles pour les actualités. #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelanieMEB
added
👀 Tech Review Needed
team-evaluation
|
I'm deploying this PR to these urls:
Please check it out! |
yannbertrand
approved these changes
Nov 18, 2021
| @@ -141,3 +141,15 @@ | |||
| color: $grey-45; | |||
| } | |||
| } | |||
|
|
|||
| .sr-only { | |||
There was a problem hiding this comment.
Je me pose la question de où mettre cette classe mais je n'ai pas de meilleure proposition 🤔
alexandrecoin
approved these changes
Nov 18, 2021
github-actions
bot
force-pushed
the
tech-add-title-for-accessibility
branch
from
0820c1f to
08f90d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Les titres des components NewsCards devaient être des H2 ou des H3 selon la page affichée.
🤖 Solution
Ajouter un titre de niveau H2, non visible, sur la page d'actualité pour pouvoir mettre du h3 à chaque fois.
🌈 Remarques
💯 Pour tester
Vérifier la hierarchie des titres sur la page d'accueil et sur la page actualités.