Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ajouter un ID sur les slices pour faire des liens dessus (PIX-1576). #228

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

MelanieMEB
Copy link
Member

🦄 Problème

La comm ne pouvait plus faire de lien sur des parties précises du site

🤖 Solution

Ajouter un ID aux Slices

🌈 Remarques

  • En cas de titre vide, on ajoute quand même un ID aléatoire

💯 Pour tester

  • Se déplacer dans le site voir qu'aucune slice n'est cassé
  • Tester d'attendre une slice directement via url#id

@MelanieMEB MelanieMEB added 👀 Tech Review Needed cross-team Toutes les équipes de dev labels Nov 27, 2020
@MelanieMEB MelanieMEB self-assigned this Nov 27, 2020
@pix-service
Copy link

I'm deploying this PR to these urls:

Please check it out!

@MelanieMEB MelanieMEB force-pushed the pix-1576-add-id-to-slice branch 2 times, most recently from 088c147 to 6e0b707 Compare November 27, 2020 14:36
services/text-to-id.js Outdated Show resolved Hide resolved
tests/services/text-to-id.test.js Outdated Show resolved Hide resolved
components/slices/Article.vue Outdated Show resolved Hide resolved
@MelanieMEB MelanieMEB force-pushed the pix-1576-add-id-to-slice branch 2 times, most recently from 9242e7b to be92e30 Compare November 30, 2020 13:43
@MelanieMEB MelanieMEB added the team-evaluation PR relatives à l'expérience d'évaluation label Nov 30, 2020
@MelanieMEB MelanieMEB merged commit a45031c into dev Nov 30, 2020
@MelanieMEB MelanieMEB deleted the pix-1576-add-id-to-slice branch November 30, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team Toutes les équipes de dev 👀 Tech Review Needed team-evaluation PR relatives à l'expérience d'évaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants