[CLEANUP] Retirer la balise H1 déjà prise en compte par prismic-rich-text. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelanieMEB
added
👀 Tech Review Needed
team-evaluation
Thomasevano
approved these changes
Oct 12, 2020
celineung
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Dans les
simple-page, comme la page /accessibilite, il y avait 2 balises H1.Vu que dans Prismic, on précise déjà que le titre est en H1, la balise
prismic-rich-textajoutait déjà une balise H1. Donc la notre faisait doublon.🤖 Solution
Retirer la balise H1 que nous avions
🌈 Pour tester :
✨ Review App
https://site-pr192.review.pix.fr/
https://pro-pr192.review.pix.fr/