[FEATURE] Ajouter un nouveau slice logos (PIX-1199). #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celineung
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
celineung
force-pushed
the
pix-1199-new-logo-block
branch
2 times, most recently
from
8d9954f to
93e49e3
Compare
celineung
force-pushed
the
pix-1199-new-logo-block
branch
2 times, most recently
from
f94d2da to
f519f79
Compare
sbedeau
suggested changes
Oct 8, 2020
MelanieMEB
approved these changes
Oct 9, 2020
alexandrecoin
force-pushed
the
pix-1199-new-logo-block
branch
from
f519f79 to
a96253e
Compare
alexandrecoin
force-pushed
the
pix-1199-new-logo-block
branch
from
d4dc0a2 to
e007182
Compare
sbedeau
suggested changes
Oct 12, 2020
alexandrecoin
force-pushed
the
pix-1199-new-logo-block
branch
from
e007182 to
8e15c36
Compare
celineung
commented
Oct 13, 2020
celineung
force-pushed
the
pix-1199-new-logo-block
branch
from
75550d2 to
ecdbe1e
Compare
sbedeau
approved these changes
Oct 13, 2020
jonasgrilleres
approved these changes
Oct 13, 2020
Process and Logos components have the same css class name. Because of that, the logos take the style of the process, which we don't want. So we need to encasulate the process css for it to be only used by the process component.
alexandrecoin
force-pushed
the
pix-1199-new-logo-block
branch
from
ecdbe1e to
7941b7b
Compare
alexandrecoin
added
Func Review OK
Tech Review OK
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
alexandrecoin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Dans le cadre de la refonte du site vitrine, on souhaiterait avoir des blocs réutilisables.
🤖 Solution
Créer la nouvelle slice Logos
🌈 Remarques
Dans la nouvelle navigation: on a un composant qui s'appelle
LogosZone.Dans une page, on peut ajouter un composant
Logos.Qu'est-ce que vous pensez du nommage?
Pour clarifier on peut renommer:
NavigationLogosZone(du coup préfixer tous les noms des composants de la navigation parNavigation)PartnerLogosmais est-ce que cette slice sera toujours utilisée pour y mettre des logos partner?✨ Review App
https://site-pr186.review.pix.fr/
https://pro-pr186.review.pix.fr/