Precise fallback meta description

1024pix · Feb 19, 2021 · b11e36e · b11e36e
1 parent d4546c8
commit b11e36e
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 14 deletions.
diff --git a/nuxt.config.js b/nuxt.config.js
@@ -30,7 +30,8 @@ export default {
       {
         hid: 'description',
         name: 'description',
-        content: process.env.npm_package_description || '',
+        content:
+          'Pix est le service public en ligne pour évaluer, développer et certifier ses compétences numériques tout au long de la vie.',
       },
     ],
     link: [

diff --git a/services/meta-builder.js b/services/meta-builder.js
@@ -1,3 +1,6 @@
+export const fallbackDescription =
+  'Pix est le service public en ligne pour évaluer, développer et certifier ses compétences numériques tout au long de la vie.'
+
 export default function getMeta(meta, currentPagePath, prismic) {
   function getTwitterCard() {
     const twitterMeta = meta.find((meta) => meta.slice_type === 'twitter_card')
@@ -39,7 +42,8 @@ export default function getMeta(meta, currentPagePath, prismic) {
       {
         hid: 'og:description',
         property: 'og:description',
-        content: prismic.asText(ogMeta.primary.description),
+        content:
+          prismic.asText(ogMeta.primary.description) || fallbackDescription,
       },
       { hid: 'og:type', property: 'og:type', content: 'article' },
       {
@@ -65,7 +69,9 @@ export default function getMeta(meta, currentPagePath, prismic) {
       {
         hid: 'description',
         name: 'description',
-        content: prismic.asText(generalCard.primary.description),
+        content:
+          prismic.asText(generalCard.primary.description) ||
+          fallbackDescription,
       },
     ]
   }

diff --git a/tests/pages/pix-site/__snapshots__/index.test.js.snap b/tests/pages/pix-site/__snapshots__/index.test.js.snap
@@ -1,13 +1,5 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Index Page get the corrects meta 1`] = `
-VueWrapper {
-  "_emitted": Object {},
-  "_emittedByOrder": Array [],
-  "isFunctionalComponent": undefined,
-}
-`;
-
 exports[`Index Page renders properly 1`] = `
 "<div class=\\"index\\">
   <slice-zone-stub slices=\\"[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object]\\"></slice-zone-stub>

diff --git a/tests/pages/pix-site/index.test.js b/tests/pages/pix-site/index.test.js
@@ -1,7 +1,7 @@
 import VueMeta from 'vue-meta'
 import { getInitialised, createLocalVue } from './utils'
 import { documentFetcher } from '~/services/document-fetcher'
-import getMeta from '~/services/meta-builder'
+import getMeta, { fallbackDescription } from '~/services/meta-builder'
 
 const localVue = createLocalVue()
 localVue.prototype.$getMeta = getMeta
@@ -63,16 +63,30 @@ describe('Index Page', () => {
     expect(wrapper.html()).toMatchSnapshot()
   })
 
-  test('get correct title info', () => {
+  test('gets the correct title', () => {
     expect(wrapper.vm.$metaInfo.title).toBe(`${PRISMIC_TITLE} | Pix`)
     expect(wrapper.vm.$data.title).toBe(PRISMIC_TITLE)
   })
 
-  test('get the corrects meta', () => {
+  test('gets the correct meta description from Prismic', () => {
     expect(findMetaContent('og:description')).toBe(PRISMIC_META)
     expect(findMetaContent('description')).toBe(PRISMIC_META)
   })
 
+  test('uses the fallback meta description when not filled in Prismic', async () => {
+    wrapper = await getInitialised('index', {
+      localVue,
+      computed: {
+        $prismic() {
+          return { asText: () => '' }
+        },
+      },
+    })
+
+    expect(findMetaContent('og:description')).toBe(fallbackDescription)
+    expect(findMetaContent('description')).toBe(fallbackDescription)
+  })
+
   function findMetaContent(hid) {
     const meta = wrapper.vm.$metaInfo.meta.find((m) => m.hid === hid)
     expect(meta).toBeTruthy()