Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FontMetrics: stringnumber #1487

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Refactor FontMetrics: stringnumber #1487

merged 1 commit into from
Dec 13, 2022

Conversation

rvilarl
Copy link
Collaborator

@rvilarl rvilarl commented Dec 12, 2022 •
edited
Loading

In order to facilitate the review of #1486 this PR includes only the changes related to StringNumber:

  • definition of StringNumberMetrics
  • movement of these metrics outside the glyphs section.

It is a step to address #1485

AaronDavidNewman
AaronDavidNewman approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@AaronDavidNewman AaronDavidNewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@rvilarl
Copy link
Collaborator Author

rvilarl commented Dec 13, 2022

@AaronDavidNewman thanks for the review! I will merge and make a PR with the next step.

@rvilarl rvilarl merged commit 3e13629 into 0xfe:master Dec 13, 2022
@rvilarl rvilarl mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronDavidNewman AaronDavidNewman AaronDavidNewman approved these changes

@ronyeh ronyeh Awaiting requested review from ronyeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvilarl @AaronDavidNewman