-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easily compare images in the current/ and reference/ folders #1484
Conversation
Looks very good!
Thanks @ronyeh |
6e4764f
to
b369ee9
Compare
Open There are 4 different view modes, accessible via number keys:
There probably are small bugs, but this is good enough to help us review Gonville SMuFL. Once we review the changes, I am comfortable merging the new Gonville as long as we agree to continue to improve it so that it more closely matches: If the visual changes from 4.1.0 are noticeable enough, and we can't (or won't) fix, then the next official release will be 5.0. |
By the way @rvilarl I updated docs/api. Please pull down these changes before any future PR merges. :-) |
@ronyeh the empty README was on purpose? |
:-) I am writing it right now. I will submit it in a later PR. |
I built a tool to help us compare the output of two VexFlow versions.
This can help us understand the changes we are introducing with each PR.
I still need to test a bit more, but try it out and let me know what you think!
Load
vexflow/tools/compare/index.html
in your local browser. Then drag a folder with thecurrent
andreference
images onto the page. You can then type some search terms to narrow down the list to the images you want to inspect (e.g., "gonv bach" will find the Bach demo tests in the Gonville font).