initial comments/proposed changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wminshew
force-pushed
the
wm-review-2
branch
2 times, most recently
from
2978291 to
7312fde
Compare
r0ohafza
reviewed
Jan 25, 2024
mihoward21
reviewed
Jan 25, 2024
mihoward21
reviewed
Jan 25, 2024
mihoward21
reviewed
Jan 25, 2024
mihoward21
reviewed
Jan 25, 2024
mihoward21
reviewed
Jan 25, 2024
r0ohafza
reviewed
Jan 25, 2024
r0ohafza
reviewed
Jan 25, 2024
r0ohafza
reviewed
Jan 26, 2024
| @@ -207,6 +208,7 @@ contract ERC6909X is ERC6909, EIP712, Nonces, IERC6909X { | |||
| ); | |||
| } | |||
|
|
|||
| /// what is this exposed for? | |||
| function DOMAIN_SEPARATOR() external view virtual returns (bytes32) { | |||
There was a problem hiding this comment.
useful for anyone trying to integrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mihoward21