Skip to content

Commit

Permalink
fix: using MultiSignerLib
Browse files Browse the repository at this point in the history
  • Loading branch information
r0ohafza committed Aug 10, 2024
1 parent aeb1ace commit f327640
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/smart-vaults/src/utils/MultiSigner.sol
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { Signer } from "../signers/Signer.sol";
* @dev Base on Coinbase's Smart Wallet Multi Ownable (https://github.com/coinbase/smart-wallet)
*/
abstract contract MultiSigner {
using MultiSignerLib for MultiSignerLib.MultiSignerStorage;

This comment has been minimized.

Copy link
@wminshew

wminshew Aug 12, 2024

Contributor

i think you can make this a global declaration in the MultiSignerLib file?

/* -------------------------------------------------------------------------- */
/* CONSTANTS */
/* -------------------------------------------------------------------------- */
Expand Down Expand Up @@ -170,7 +171,7 @@ abstract contract MultiSigner {
MultiSignerLib.MultiSignerStorage storage $ = _getMultiSignerStorage();

for (uint8 i; i < numSigners; i++) {
MultiSignerLib.setSigner($, signers_[i], i);
$.setSigner(signers_[i], i);

emit AddSigner(i, signers_[i]);
}
Expand All @@ -185,7 +186,7 @@ abstract contract MultiSigner {

if (!$.signers[index_].isEmptyMem()) revert SignerAlreadyPresent(index_);

MultiSignerLib.setSigner($, signer_, index_);
$.setSigner(signer_, index_);
$.signerCount += 1;

emit AddSigner(index_, signer_);
Expand Down

0 comments on commit f327640

Please sign in to comment.