Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix rpc_declare_transaction logic to also return DeclareV2 #500

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Fix rpc_declare_transaction logic to also return DeclareV2 #500

merged 5 commits into from
Jun 14, 2023

Conversation

tomek0123456789
Copy link
Contributor

Usage related changes

  • getBlockWithTxs, getBlockWithTxHashes and getTransactionByHash now can return DeclareV2 transaction

Development related changes

  • changed rpc_declare_transaction function to match RPC spec

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@FabijanC FabijanC self-requested a review June 14, 2023 11:09
FabijanC
FabijanC suggested changes Jun 14, 2023
View reviewed changes
starknet_devnet/blueprints/rpc/structures/payloads.py Outdated Show resolved Hide resolved
test/rpc/test_rpc_transactions.py Show resolved Hide resolved
starknet_devnet/blueprints/rpc/structures/payloads.py Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit 1b7a7d9 into 0xSpaceShard:master Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomek0123456789 @FabijanC